Skip to content
Snippets Groups Projects
  1. Sep 25, 2020
    • Calvin Walton's avatar
      Perform captions generation in UTF-16 encoding · 1866eb71
      Calvin Walton authored
      The indexes returned in recording events from BBB refer to positions
      within a UTF-16 encoded string. Rather than attempt to untangle this in
      the server (which might have a performance cost), it's easier to switch
      the caption processing code to operate in UTF-16 encoding as well to
      make it work consistently.
      
      The PyICU library provides a UnicodeString type which is a UTF-16 string
      similar to Java and JavaScript, but which supports all the python
      indexing methods. It's fairly straightforwards to swap it in in place of
      the types used previously, and works natively as an input to the ICU
      line break iterator too.
      
      Fixes #10531
      1866eb71
  2. Sep 23, 2020
    • Calvin Walton's avatar
      Fix io deadlock in recording scripts process execution utilities · 12687535
      Calvin Walton authored
      The previous implementation of the BigBlueButton.execute method runs the
      process with separate stdout and stderr streams. It first reads all of
      the output from stdout, then reads all of the output from stderr.
      
      This can cause a deadlock if the process writes a lot of data to stderr.
      The IO buffer for stderr could fill, blocking progress. But since it
      hasn't closed stdout, the ruby script is still waiting on a read to
      stdout.
      
      Switch to an execution method (using IO.popen) that allows combining
      stdout and stderr into a single stream, eliminating the issue.
      12687535
  3. Aug 13, 2020
    • hiroshisuga's avatar
      events_archiver.rb: Handle an empty meeting_metadata hash from redis · 3cbe9aba
      hiroshisuga authored
      On my server 2.3 alpha, the method metadata_for(meeting_id) gives back {}
      (empty Hash). Thus "return if meeting_metadata.nil?" does not occur.
      
      Does @redis.hgetall give {} instead of nil, even though there is a comment in
      node_modules/redis/lib/utils.js "hgetall converts its replies to an Object. If
      the reply is empty, null is returned"???
      3cbe9aba
  4. Jun 24, 2020
  5. Jun 17, 2020
    • mw781's avatar
      Ensure that files are handled safely 2 · f60059c9
      mw781 authored
      f60059c9
    • mw781's avatar
      Ensure that files are handled safely · fea0ff32
      mw781 authored
      This commit fixes an issue with reading and writing files.
      File.open is used which means that a file will remain open
      unless explicilty closed or the program exit. This doesn't work
      for an NFS mount as the scripts try to "rm -rf" when the file
      is still open. This commit fixes that by replacing all .opens
      with .reads
      fea0ff32
  6. May 23, 2020
  7. May 16, 2020
  8. Apr 29, 2020
  9. Apr 27, 2020
  10. Apr 06, 2020
  11. Apr 01, 2020
  12. Mar 27, 2020
    • Calvin Walton's avatar
      Have the recording archive delete originals of archived media · a5a46b2c
      Calvin Walton authored
      After the last segment of a recording has been archived, it is safe to
      delete the original files that were recorded by the various media
      handling components. This patch deletes the freeswitch audio files and
      kurento webcam/screenshare files after they have been archived.
      
      It needs to be used in combination with some changes to users/groups and
      directory permissions to allow the `bigbluebutton` user to delete files
      that it could previously only read.
      a5a46b2c
  13. Feb 29, 2020
  14. Dec 19, 2019
  15. Nov 20, 2019
  16. Nov 08, 2019
  17. Oct 30, 2019
  18. Oct 28, 2019
  19. Oct 23, 2019
  20. Oct 22, 2019
  21. Oct 21, 2019
  22. Oct 18, 2019
    • Calvin Walton's avatar
      Make presentation playback continue if deskshare.xml was not found · 69aa493d
      Calvin Walton authored
      Someone on the mailing list had some recordings which were using the 2.0
      playback, but were missing the deskshare.xml file (which should always
      be present for 2.0… strange). It's safe to continue loading the recording
      playback if the deskshare.xml file is not found, the recording will just act
      as if there were no deskshare start/stop events.
      69aa493d
  23. Oct 09, 2019
  24. Oct 07, 2019
    • Calvin Walton's avatar
      Fix deskshare media sync when deskshare loads before webcam/audio · d5097fa4
      Calvin Walton authored
      If the secondary media loaded before the main media, it would run the
      "setMediaSync" function before the main media player was setup. As a
      side-effect of setting up the main media player, all of the event handlers
      added by the setMediaSync function are detached, and so the secondary
      media never starts playing.
      
      Move the call to setMediaSync to after the media-ready events for all
      media have fired, so that it can reliably attach the event handlers.
      d5097fa4
  25. Oct 04, 2019
  26. Sep 23, 2019
    • Ghazi Triki's avatar
      Fix screeshare rap (#7939) · b4c5d2cc
      Ghazi Triki authored
      Adapt the screenshare processing script to changes to the api for events handling in
      the recording-and-playback core libs.
      b4c5d2cc
    • Calvin Walton's avatar
      Fix autoplay of deskshare video in presentation playback format · 11fac78a
      Calvin Walton authored
      This reverts a bbb-specific customization made in the jquery.acornmediaplayer.js
      file: it's restored to what the upstream player did. I can't find any explanation
      for why this change was made in the first place? Reverting it doesn't seem to
      cause any playback issues (Popcorn still works, in particular).
      11fac78a
  27. Aug 20, 2019
  28. Jul 31, 2019
  29. Jul 10, 2019
  30. Jul 05, 2019
  31. Jul 04, 2019
  32. Jun 14, 2019
Loading