Skip to content
Snippets Groups Projects
  1. Oct 06, 2020
  2. Oct 02, 2020
  3. Oct 01, 2020
  4. Sep 30, 2020
  5. Sep 29, 2020
  6. Sep 28, 2020
    • Pedro Beschorner Marin's avatar
      Patch of improvements for bbb-web · 2fb26ff0
      Pedro Beschorner Marin authored
      This patch includes two improvements made for bbb-web. It tries to better isolate
      the sessionToken's handling and session's validation, including logs for each one of
      these steps; and removes maxParticipats control from registered users (that are no
      longer removed from bbb-web collections) binding it to joined users or users that
      reached the enter API call. The following adds more details about this last one:
      
      User's regular flow to join a meeting goes around an API join call -> redis register event ->
      redirect to client page -> API enter call -> redis join event. When the guest policy is ASK_MODERATOR,
      non-moderators are registered and redirected to a guest lobby that polls for her/his guest status and
      only enters the meeting after a moderator approval.
      Using registered users as control to check how many participants are in a meeting is problematic because
      non-approved guests are counted as participants and bbb-web has to find out when to ditch registered users
      records to make a seat in a meeting available again. In other words, a meeting with maxParicipants
      of 5 can get it's joins locked with a moderator and 4 waiting guests or bbb-web can wrongly drop a registered
      user record on a reconnection inducing weird 401 responses from the API.
      
      This change proposes to control maxParticipants both at join and enter API calls monitoring the number
      of redis joined users. This also includes an extra buffer to capture users that called the enter API but
      still don't have an user joined event.
      User left events are now handled different holding the user data before removing from the joined users collection
      and only releasing after verifying that the user didn't reconnected.
      
      Both user left timeout `usersTimeout` and entered user timeout `enteredUsersTimeout` can be configured at properties.
      2fb26ff0
  7. Sep 25, 2020
  8. Sep 24, 2020
  9. Sep 23, 2020
    • Dixon Fred's avatar
      Merge pull request #10516 from kepstin/recording-proc-deadlock · 9f4720d1
      Dixon Fred authored
      Fix io deadlock in recording scripts process execution utilities
      Unverified
      9f4720d1
    • Calvin Walton's avatar
      Fix io deadlock in recording scripts process execution utilities · 12687535
      Calvin Walton authored
      The previous implementation of the BigBlueButton.execute method runs the
      process with separate stdout and stderr streams. It first reads all of
      the output from stdout, then reads all of the output from stderr.
      
      This can cause a deadlock if the process writes a lot of data to stderr.
      The IO buffer for stderr could fill, blocking progress. But since it
      hasn't closed stdout, the ruby script is still waiting on a read to
      stdout.
      
      Switch to an execution method (using IO.popen) that allows combining
      stdout and stderr into a single stream, eliminating the issue.
      12687535
Loading