Skip to content
Snippets Groups Projects
  1. Mar 11, 2021
  2. Mar 10, 2021
  3. Mar 08, 2021
  4. Mar 02, 2021
  5. Feb 09, 2021
  6. Dec 21, 2020
  7. Dec 20, 2020
  8. Dec 10, 2020
  9. Dec 07, 2020
  10. Dec 06, 2020
  11. Dec 04, 2020
  12. Sep 25, 2020
    • Calvin Walton's avatar
      Recording: Skip shapes with missing "thickness" attribute · 86c821f4
      Calvin Walton authored
      Not sure what causes this issue, but there's nothing reasonable that can
      be done to draw a shape with no thickness. Just skip it.
      86c821f4
    • Calvin Walton's avatar
      Perform captions generation in UTF-16 encoding · 1866eb71
      Calvin Walton authored
      The indexes returned in recording events from BBB refer to positions
      within a UTF-16 encoded string. Rather than attempt to untangle this in
      the server (which might have a performance cost), it's easier to switch
      the caption processing code to operate in UTF-16 encoding as well to
      make it work consistently.
      
      The PyICU library provides a UnicodeString type which is a UTF-16 string
      similar to Java and JavaScript, but which supports all the python
      indexing methods. It's fairly straightforwards to swap it in in place of
      the types used previously, and works natively as an input to the ICU
      line break iterator too.
      
      Fixes #10531
      1866eb71
  13. Sep 23, 2020
    • Calvin Walton's avatar
      Fix io deadlock in recording scripts process execution utilities · 12687535
      Calvin Walton authored
      The previous implementation of the BigBlueButton.execute method runs the
      process with separate stdout and stderr streams. It first reads all of
      the output from stdout, then reads all of the output from stderr.
      
      This can cause a deadlock if the process writes a lot of data to stderr.
      The IO buffer for stderr could fill, blocking progress. But since it
      hasn't closed stdout, the ruby script is still waiting on a read to
      stdout.
      
      Switch to an execution method (using IO.popen) that allows combining
      stdout and stderr into a single stream, eliminating the issue.
      12687535
  14. Sep 01, 2020
  15. Aug 13, 2020
    • hiroshisuga's avatar
      events_archiver.rb: Handle an empty meeting_metadata hash from redis · 3cbe9aba
      hiroshisuga authored
      On my server 2.3 alpha, the method metadata_for(meeting_id) gives back {}
      (empty Hash). Thus "return if meeting_metadata.nil?" does not occur.
      
      Does @redis.hgetall give {} instead of nil, even though there is a comment in
      node_modules/redis/lib/utils.js "hgetall converts its replies to an Object. If
      the reply is empty, null is returned"???
      3cbe9aba
    • hiroshisuga's avatar
      events_archiver.rb: Handle an empty meeting_metadata hash from redis · dc0fc459
      hiroshisuga authored
      On my server 2.3 alpha, the method metadata_for(meeting_id) gives back {}
      (empty Hash). Thus "return if meeting_metadata.nil?" does not occur.
      
      Does @redis.hgetall give {} instead of nil, even though there is a comment in
      node_modules/redis/lib/utils.js "hgetall converts its replies to an Object. If
      the reply is empty, null is returned"???
      dc0fc459
  16. Aug 11, 2020
    • Calvin Walton's avatar
      Events archiver: Strip more invalid characters · 65989305
      Calvin Walton authored
      Update the list of invalid characters based on what the XML
      specification permits and discourages.
      
      Use the ruby string `scrub` method to remove invalid characters that
      can't be expressed in the `tr` syntax, like unpaired surrogates and
      UTF-8 prefix bytes.
      65989305
  17. Jul 30, 2020
  18. Jul 17, 2020
  19. Jul 01, 2020
  20. Jun 26, 2020
  21. Jun 24, 2020
  22. Jun 17, 2020
    • mw781's avatar
      Ensure that files are handled safely 2 · f60059c9
      mw781 authored
      f60059c9
    • mw781's avatar
      Ensure that files are handled safely · fea0ff32
      mw781 authored
      This commit fixes an issue with reading and writing files.
      File.open is used which means that a file will remain open
      unless explicilty closed or the program exit. This doesn't work
      for an NFS mount as the scripts try to "rm -rf" when the file
      is still open. This commit fixes that by replacing all .opens
      with .reads
      fea0ff32
  23. May 23, 2020
  24. May 16, 2020
  25. May 10, 2020
  26. Apr 29, 2020
  27. Apr 27, 2020
Loading