Skip to content
Snippets Groups Projects
Commit 01db702c authored by Armin Felder's avatar Armin Felder
Browse files

std::move arguments from construtors

parent 6eeac50a
Branches ClangTidy
No related tags found
1 merge request!69Improved emoji loading
This commit is part of merge request !69. Comments created here will be created in the context of that merge request.
......@@ -28,12 +28,12 @@ DDPRequest::DDPRequest( const QJsonObject &pRequest ): mRawRequest( pRequest )
}
DDPRequest::DDPRequest( const QJsonObject &pRequest, const DdpCallback &pSuccess ): mRawRequest( pRequest ), mSuccess( pSuccess )
DDPRequest::DDPRequest( const QJsonObject &pRequest, DdpCallback pSuccess ): mRawRequest( pRequest ), mSuccess( std::move( pSuccess ) )
{
}
DDPRequest::DDPRequest( const QJsonObject &pRequest, const DdpCallback &pSuccess, const DdpCallback &error ): mRawRequest( pRequest ), mSuccess( pSuccess ), mError( error )
DDPRequest::DDPRequest( const QJsonObject &pRequest, DdpCallback pSuccess, DdpCallback error ): mRawRequest( pRequest ), mSuccess( std::move( pSuccess ) ), mError( std::move( error ) )
{
}
......
......@@ -34,8 +34,8 @@ class DDPRequest : public QObject
Q_OBJECT
public:
DDPRequest( const QJsonObject &pRequest );
DDPRequest( const QJsonObject &pRequest, const DdpCallback &pSuccess );
DDPRequest( const QJsonObject &pRequest, const DdpCallback &pSuccess, const DdpCallback &pError );
DDPRequest( const QJsonObject &pRequest, DdpCallback pSuccess );
DDPRequest( const QJsonObject &pRequest, DdpCallback pSuccess, DdpCallback pError );
QJsonObject getRawRequest() const;
QString getFrame() const;
void setFrame( const QString &value );
......
......@@ -21,7 +21,7 @@
#include "emoji.h"
Emoji::Emoji( const QString &name, const QString &extension, const QString &category ): mCategory( category )
Emoji::Emoji( QString name, QString extension, QString category ): mCategory( std::move( category ) )
{
this->mIdentifier = ':' + name + ':';
......@@ -30,7 +30,7 @@ Emoji::Emoji( const QString &name, const QString &extension, const QString &cate
this->mType = QStringLiteral( "emoji" );
}
Emoji::Emoji( const QString &name, const QString &category, const QString &filePath, const QString &html ): mCategory( category )
Emoji::Emoji( QString name, QString category, QString filePath, QString html ): mCategory( std::move( category ) )
{
this->mIdentifier = name;
QFileInfo fileInfo( filePath );
......@@ -39,7 +39,7 @@ Emoji::Emoji( const QString &name, const QString &category, const QString &fileP
mExtension = fileInfo.completeSuffix();
}
Emoji::Emoji( const QString &name, const QString &category, const QString &filePath, const QString &html, const QString &unicode ): mCategory( category ), mUnicodeChar( unicode )
Emoji::Emoji( QString name, QString category, QString filePath, QString html, QString unicode ): mCategory( std::move( category ) ), mUnicodeChar( std::move( unicode ) )
{
this->mIdentifier = name;
QFileInfo fileInfo( filePath );
......@@ -48,7 +48,7 @@ Emoji::Emoji( const QString &name, const QString &category, const QString &fileP
mExtension = fileInfo.completeSuffix();
}
Emoji::Emoji( const QString &name, const QString &category, const QString &filePath, const QString &html, const QString &unicode, int order ): mCategory( category ), mUnicodeChar( unicode ), mOrder( order )
Emoji::Emoji( QString name, QString category, QString filePath, QString html, QString unicode, int order ): mCategory( std::move( category ) ), mUnicodeChar( std::move( unicode ) ), mOrder( order )
{
this->mIdentifier = name;
QFileInfo fileInfo( filePath );
......
......@@ -29,10 +29,10 @@
class Emoji : public TempFile
{
public:
Emoji( const QString &name, const QString &extension, const QString &category );
Emoji( const QString &name, const QString &category, const QString &file, const QString &html );
Emoji( const QString &name, const QString &category, const QString &file, const QString &html, const QString &unicode );
Emoji( const QString &name, const QString &category, const QString &file, const QString &html, const QString &unicode, int order );
Emoji( QString name, QString extension, QString category );
Emoji( QString name, QString category, QString file, QString html );
Emoji( QString name, QString category, QString file, QString html, QString unicode );
Emoji( QString name, QString category, QString file, QString html, QString unicode, int order );
QString getIdentifier() const;
QVariantMap toQVariantMap();
......
......@@ -22,7 +22,7 @@
#include "rocketchatuser.h"
RocketChatUser::RocketChatUser( const QString &pId ): mUserId( pId )
RocketChatUser::RocketChatUser( QString pId ): mUserId( std::move( pId ) )
{
}
......
......@@ -37,7 +37,7 @@ class RocketChatUser : public QObject
OFFLINE = 2,
BUSY = 3
};
explicit RocketChatUser( const QString &pId ) ;
explicit RocketChatUser( QString pId ) ;
QString getUserName() const;
void setUserName( const QString &pValue );
......
......@@ -23,7 +23,7 @@
#include "CustomModels/models.h"
RocketChatServerData::RocketChatServerData( const QString &pId, QString pBaseUrl, bool pUnsecure ): mBaseUrl( pBaseUrl ), mServerId( pId ), userModel( Models::getUsersModel() ), loginMethodsModel( Models::getLoginMethodsModel() ), channelsModel( Models::getPublicGroupsModel() ),
RocketChatServerData::RocketChatServerData( QString pId, QString pBaseUrl, bool pUnsecure ): mBaseUrl( std::move( pBaseUrl ) ), mServerId( std::move( pId ) ), userModel( Models::getUsersModel() ), loginMethodsModel( Models::getLoginMethodsModel() ), channelsModel( Models::getPublicGroupsModel() ),
directModel( Models::getDirectChannelsModel() ), groupsModel( Models::getPublicGroupsModel() )
{
qRegisterMetaType<User>( "User" );
......
......@@ -115,7 +115,7 @@ class RocketChatServerData : public MessageListener
Q_OBJECT
public:
RocketChatServerData( const QString &pId, QString pBaseUrl,
RocketChatServerData( QString pId, QString pBaseUrl,
bool pUnsecure = false );
void setServerId( const QString &pValue );
......
......@@ -27,17 +27,17 @@ LoadHistoryServiceRequest::LoadHistoryServiceRequest( const QString &pChannelId
}
LoadHistoryServiceRequest::LoadHistoryServiceRequest( const QStringList &pChannelIds ): mChannelIds( pChannelIds )
LoadHistoryServiceRequest::LoadHistoryServiceRequest( QStringList pChannelIds ): mChannelIds( std::move( pChannelIds ) )
{
}
LoadHistoryServiceRequest::LoadHistoryServiceRequest( const QString &pChannelId, int pLimit ): LoadHistoryServiceRequest( pChannelId )
LoadHistoryServiceRequest::LoadHistoryServiceRequest( QString pChannelId, int pLimit ): LoadHistoryServiceRequest( std::move( pChannelId ) )
{
mLimit = pLimit;
}
LoadHistoryServiceRequest::LoadHistoryServiceRequest( const QStringList &pChannelIds, int pLimit ): LoadHistoryServiceRequest( pChannelIds )
LoadHistoryServiceRequest::LoadHistoryServiceRequest( QStringList pChannelIds, int pLimit ): LoadHistoryServiceRequest( std::move( pChannelIds ) )
{
mLimit = pLimit;
}
......
......@@ -32,9 +32,9 @@ class LoadHistoryServiceRequest
{
public:
LoadHistoryServiceRequest( const QString &pChannelId );
LoadHistoryServiceRequest( const QStringList &pChannelIds );
LoadHistoryServiceRequest( const QString &pChannelId, int pLimit );
LoadHistoryServiceRequest( const QStringList &pChannelIds, int pLimit );
LoadHistoryServiceRequest( QStringList pChannelIds );
LoadHistoryServiceRequest( QString pChannelId, int pLimit );
LoadHistoryServiceRequest( QStringList pChannelIds, int pLimit );
enum class Source {
AUTO,
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment