diff --git a/ddpRequests/ddprequest.cpp b/ddpRequests/ddprequest.cpp index b3c65acf3059c9b7e1eadf297d3830856d87da90..1c3aa474fe3490d633604a308f727b441bf97c0f 100755 --- a/ddpRequests/ddprequest.cpp +++ b/ddpRequests/ddprequest.cpp @@ -28,12 +28,12 @@ DDPRequest::DDPRequest( const QJsonObject &pRequest ): mRawRequest( pRequest ) } -DDPRequest::DDPRequest( const QJsonObject &pRequest, const DdpCallback &pSuccess ): mRawRequest( pRequest ), mSuccess( pSuccess ) +DDPRequest::DDPRequest( const QJsonObject &pRequest, DdpCallback pSuccess ): mRawRequest( pRequest ), mSuccess( std::move( pSuccess ) ) { } -DDPRequest::DDPRequest( const QJsonObject &pRequest, const DdpCallback &pSuccess, const DdpCallback &error ): mRawRequest( pRequest ), mSuccess( pSuccess ), mError( error ) +DDPRequest::DDPRequest( const QJsonObject &pRequest, DdpCallback pSuccess, DdpCallback error ): mRawRequest( pRequest ), mSuccess( std::move( pSuccess ) ), mError( std::move( error ) ) { } diff --git a/ddpRequests/ddprequest.h b/ddpRequests/ddprequest.h index 34d3d4057fe99a6faf7cb3d959c6a052dbd3d758..e925b27c8ec3f6d150993cce11324d00a7b41543 100755 --- a/ddpRequests/ddprequest.h +++ b/ddpRequests/ddprequest.h @@ -34,8 +34,8 @@ class DDPRequest : public QObject Q_OBJECT public: DDPRequest( const QJsonObject &pRequest ); - DDPRequest( const QJsonObject &pRequest, const DdpCallback &pSuccess ); - DDPRequest( const QJsonObject &pRequest, const DdpCallback &pSuccess, const DdpCallback &pError ); + DDPRequest( const QJsonObject &pRequest, DdpCallback pSuccess ); + DDPRequest( const QJsonObject &pRequest, DdpCallback pSuccess, DdpCallback pError ); QJsonObject getRawRequest() const; QString getFrame() const; void setFrame( const QString &value ); diff --git a/repos/entities/emoji.cpp b/repos/entities/emoji.cpp index 2bb9f0e574c724ea4ebacef0f6733ed1a1733448..560f5b4b8e4f2cf0a7a2424d88a69c001a081acc 100644 --- a/repos/entities/emoji.cpp +++ b/repos/entities/emoji.cpp @@ -21,7 +21,7 @@ #include "emoji.h" -Emoji::Emoji( const QString &name, const QString &extension, const QString &category ): mCategory( category ) +Emoji::Emoji( QString name, QString extension, QString category ): mCategory( std::move( category ) ) { this->mIdentifier = ':' + name + ':'; @@ -30,7 +30,7 @@ Emoji::Emoji( const QString &name, const QString &extension, const QString &cate this->mType = QStringLiteral( "emoji" ); } -Emoji::Emoji( const QString &name, const QString &category, const QString &filePath, const QString &html ): mCategory( category ) +Emoji::Emoji( QString name, QString category, QString filePath, QString html ): mCategory( std::move( category ) ) { this->mIdentifier = name; QFileInfo fileInfo( filePath ); @@ -39,7 +39,7 @@ Emoji::Emoji( const QString &name, const QString &category, const QString &fileP mExtension = fileInfo.completeSuffix(); } -Emoji::Emoji( const QString &name, const QString &category, const QString &filePath, const QString &html, const QString &unicode ): mCategory( category ), mUnicodeChar( unicode ) +Emoji::Emoji( QString name, QString category, QString filePath, QString html, QString unicode ): mCategory( std::move( category ) ), mUnicodeChar( std::move( unicode ) ) { this->mIdentifier = name; QFileInfo fileInfo( filePath ); @@ -48,7 +48,7 @@ Emoji::Emoji( const QString &name, const QString &category, const QString &fileP mExtension = fileInfo.completeSuffix(); } -Emoji::Emoji( const QString &name, const QString &category, const QString &filePath, const QString &html, const QString &unicode, int order ): mCategory( category ), mUnicodeChar( unicode ), mOrder( order ) +Emoji::Emoji( QString name, QString category, QString filePath, QString html, QString unicode, int order ): mCategory( std::move( category ) ), mUnicodeChar( std::move( unicode ) ), mOrder( order ) { this->mIdentifier = name; QFileInfo fileInfo( filePath ); diff --git a/repos/entities/emoji.h b/repos/entities/emoji.h index 79cd3f19ffe4e25fa39ff958e83da75f51e8221f..1a830a3083dd4410f74f42c04e27c42b73074ab8 100644 --- a/repos/entities/emoji.h +++ b/repos/entities/emoji.h @@ -29,10 +29,10 @@ class Emoji : public TempFile { public: - Emoji( const QString &name, const QString &extension, const QString &category ); - Emoji( const QString &name, const QString &category, const QString &file, const QString &html ); - Emoji( const QString &name, const QString &category, const QString &file, const QString &html, const QString &unicode ); - Emoji( const QString &name, const QString &category, const QString &file, const QString &html, const QString &unicode, int order ); + Emoji( QString name, QString extension, QString category ); + Emoji( QString name, QString category, QString file, QString html ); + Emoji( QString name, QString category, QString file, QString html, QString unicode ); + Emoji( QString name, QString category, QString file, QString html, QString unicode, int order ); QString getIdentifier() const; QVariantMap toQVariantMap(); diff --git a/repos/entities/rocketchatuser.cpp b/repos/entities/rocketchatuser.cpp index 66a3d4a98052b775cd929368b4a5057b79711280..ef4d8f924481f639b6036d9f491fdf15d33efb85 100755 --- a/repos/entities/rocketchatuser.cpp +++ b/repos/entities/rocketchatuser.cpp @@ -22,7 +22,7 @@ #include "rocketchatuser.h" -RocketChatUser::RocketChatUser( const QString &pId ): mUserId( pId ) +RocketChatUser::RocketChatUser( QString pId ): mUserId( std::move( pId ) ) { } diff --git a/repos/entities/rocketchatuser.h b/repos/entities/rocketchatuser.h index df7c840cf7d726e5b50409556ffd10cdf5332e00..c7c5ebedd35abc3c1f6d33bc72c368a194ed5a8b 100755 --- a/repos/entities/rocketchatuser.h +++ b/repos/entities/rocketchatuser.h @@ -37,7 +37,7 @@ class RocketChatUser : public QObject OFFLINE = 2, BUSY = 3 }; - explicit RocketChatUser( const QString &pId ) ; + explicit RocketChatUser( QString pId ) ; QString getUserName() const; void setUserName( const QString &pValue ); diff --git a/rocketchatserver.cpp b/rocketchatserver.cpp index e8c5b8b200907273437e6867b0c6155b636dc09a..fc0f4adf351d2dbcba0035b05b7fb60d85c8d43f 100755 --- a/rocketchatserver.cpp +++ b/rocketchatserver.cpp @@ -23,7 +23,7 @@ #include "CustomModels/models.h" -RocketChatServerData::RocketChatServerData( const QString &pId, QString pBaseUrl, bool pUnsecure ): mBaseUrl( pBaseUrl ), mServerId( pId ), userModel( Models::getUsersModel() ), loginMethodsModel( Models::getLoginMethodsModel() ), channelsModel( Models::getPublicGroupsModel() ), +RocketChatServerData::RocketChatServerData( QString pId, QString pBaseUrl, bool pUnsecure ): mBaseUrl( std::move( pBaseUrl ) ), mServerId( std::move( pId ) ), userModel( Models::getUsersModel() ), loginMethodsModel( Models::getLoginMethodsModel() ), channelsModel( Models::getPublicGroupsModel() ), directModel( Models::getDirectChannelsModel() ), groupsModel( Models::getPublicGroupsModel() ) { qRegisterMetaType<User>( "User" ); diff --git a/rocketchatserver.h b/rocketchatserver.h index cf04c770a54a9bed38c2167c6d7ee01c72120888..0e98dd8c9f72d587628c1f9422b779b0a9c58a03 100755 --- a/rocketchatserver.h +++ b/rocketchatserver.h @@ -115,7 +115,7 @@ class RocketChatServerData : public MessageListener Q_OBJECT public: - RocketChatServerData( const QString &pId, QString pBaseUrl, + RocketChatServerData( QString pId, QString pBaseUrl, bool pUnsecure = false ); void setServerId( const QString &pValue ); diff --git a/services/requests/loadhistoryservicerequest.cpp b/services/requests/loadhistoryservicerequest.cpp index f19d18fcc458e959e83fff4eb3c935a43ad1e0a1..7e3df1d19449ea146f290e84a82d5e047fbfee9d 100644 --- a/services/requests/loadhistoryservicerequest.cpp +++ b/services/requests/loadhistoryservicerequest.cpp @@ -27,17 +27,17 @@ LoadHistoryServiceRequest::LoadHistoryServiceRequest( const QString &pChannelId } -LoadHistoryServiceRequest::LoadHistoryServiceRequest( const QStringList &pChannelIds ): mChannelIds( pChannelIds ) +LoadHistoryServiceRequest::LoadHistoryServiceRequest( QStringList pChannelIds ): mChannelIds( std::move( pChannelIds ) ) { } -LoadHistoryServiceRequest::LoadHistoryServiceRequest( const QString &pChannelId, int pLimit ): LoadHistoryServiceRequest( pChannelId ) +LoadHistoryServiceRequest::LoadHistoryServiceRequest( QString pChannelId, int pLimit ): LoadHistoryServiceRequest( std::move( pChannelId ) ) { mLimit = pLimit; } -LoadHistoryServiceRequest::LoadHistoryServiceRequest( const QStringList &pChannelIds, int pLimit ): LoadHistoryServiceRequest( pChannelIds ) +LoadHistoryServiceRequest::LoadHistoryServiceRequest( QStringList pChannelIds, int pLimit ): LoadHistoryServiceRequest( std::move( pChannelIds ) ) { mLimit = pLimit; } diff --git a/services/requests/loadhistoryservicerequest.h b/services/requests/loadhistoryservicerequest.h index b64ba989e82d427d11e57e92e299f50b3ecac19e..b93ce2111cfaff9ede10d33b78e3ae1f222818f6 100644 --- a/services/requests/loadhistoryservicerequest.h +++ b/services/requests/loadhistoryservicerequest.h @@ -32,9 +32,9 @@ class LoadHistoryServiceRequest { public: LoadHistoryServiceRequest( const QString &pChannelId ); - LoadHistoryServiceRequest( const QStringList &pChannelIds ); - LoadHistoryServiceRequest( const QString &pChannelId, int pLimit ); - LoadHistoryServiceRequest( const QStringList &pChannelIds, int pLimit ); + LoadHistoryServiceRequest( QStringList pChannelIds ); + LoadHistoryServiceRequest( QString pChannelId, int pLimit ); + LoadHistoryServiceRequest( QStringList pChannelIds, int pLimit ); enum class Source { AUTO,