issue #799 merger message views (#876)
On Room Actions, we have Files, Mentions, Starred and Pinned. They have similar APIs and logic. All of those could be merged into one generic view (MessagesView). Maybe even Search could be in this merge. Note: They're similar, but have own rules (unstar, unpin, etc). This change may reduce 1MB to our release bundle size, since we're going to remove a lot of boilerplate.
Showing
- app/index.js 3 additions, 9 deletionsapp/index.js
- app/lib/methods/helpers/getFileUrlFromMessage.js 15 additions, 0 deletionsapp/lib/methods/helpers/getFileUrlFromMessage.js
- app/views/MentionedMessagesView/index.js 0 additions, 139 deletionsapp/views/MentionedMessagesView/index.js
- app/views/MessagesView/index.js 255 additions, 0 deletionsapp/views/MessagesView/index.js
- app/views/MessagesView/styles.js 0 additions, 0 deletionsapp/views/MessagesView/styles.js
- app/views/PinnedMessagesView/styles.js 0 additions, 22 deletionsapp/views/PinnedMessagesView/styles.js
- app/views/RoomActionsView/index.js 8 additions, 8 deletionsapp/views/RoomActionsView/index.js
- app/views/RoomFilesView/index.js 0 additions, 151 deletionsapp/views/RoomFilesView/index.js
- app/views/RoomFilesView/styles.js 0 additions, 22 deletionsapp/views/RoomFilesView/styles.js
- app/views/StarredMessagesView/index.js 0 additions, 184 deletionsapp/views/StarredMessagesView/index.js
- app/views/StarredMessagesView/styles.js 0 additions, 22 deletionsapp/views/StarredMessagesView/styles.js
Loading
Please register or sign in to comment