Add try/catch on video-streams methods

bigbluebutton-html5/imports/api/video-streams/server/methods/userShareWebcam.js

@@ -5,27 +5,30 @@ import RedisPubSub from '/imports/startup/server/redis';
 import { extractCredentials } from '/imports/api/common/server/helpers';
 
 export default function userShareWebcam(stream) {
-  const REDIS_CONFIG = Meteor.settings.private.redis;
-  const CHANNEL = REDIS_CONFIG.channels.toAkkaApps;
-  const EVENT_NAME = 'UserBroadcastCamStartMsg';
-  const { meetingId, requesterUserId } = extractCredentials(this.userId);
+  try {
+    const REDIS_CONFIG = Meteor.settings.private.redis;
+    const CHANNEL = REDIS_CONFIG.channels.toAkkaApps;
+    const EVENT_NAME = 'UserBroadcastCamStartMsg';
+    const { meetingId, requesterUserId } = extractCredentials(this.userId);
 
-  check(meetingId, String);
-  check(requesterUserId, String);
-  check(stream, String);
+    check(meetingId, String);
+    check(requesterUserId, String);
+    check(stream, String);
 
-  Logger.info(`user sharing webcam: ${meetingId} ${requesterUserId}`);
+    Logger.info(`user sharing webcam: ${meetingId} ${requesterUserId}`);
 
+    // const actionName = 'joinVideo';
+    /* TODO throw an error if user has no permission to share webcam
+    if (!isAllowedTo(actionName, credentials)) {
+      throw new Meteor.Error('not-allowed', `You are not allowed to share webcam`);
+    } */
 
-  // const actionName = 'joinVideo';
-  /* TODO throw an error if user has no permission to share webcam
-  if (!isAllowedTo(actionName, credentials)) {
-    throw new Meteor.Error('not-allowed', `You are not allowed to share webcam`);
-  } */
+    const payload = {
+      stream,
+    };
 
-  const payload = {
-    stream,
-  };
-
-  return RedisPubSub.publishUserMessage(CHANNEL, EVENT_NAME, meetingId, requesterUserId, payload);
+    RedisPubSub.publishUserMessage(CHANNEL, EVENT_NAME, meetingId, requesterUserId, payload);
+  } catch (err) {
+    Logger.error(`Exception while invoking method userShareWebcam ${err.stack}`);
+  }
 }

bigbluebutton-html5/imports/api/video-streams/server/methods/userUnshareWebcam.js

@@ -5,26 +5,30 @@ import RedisPubSub from '/imports/startup/server/redis';
 import { extractCredentials } from '/imports/api/common/server/helpers';
 
 export default function userUnshareWebcam(stream) {
-  const REDIS_CONFIG = Meteor.settings.private.redis;
-  const CHANNEL = REDIS_CONFIG.channels.toAkkaApps;
-  const EVENT_NAME = 'UserBroadcastCamStopMsg';
-  const { meetingId, requesterUserId } = extractCredentials(this.userId);
+  try {
+    const REDIS_CONFIG = Meteor.settings.private.redis;
+    const CHANNEL = REDIS_CONFIG.channels.toAkkaApps;
+    const EVENT_NAME = 'UserBroadcastCamStopMsg';
+    const { meetingId, requesterUserId } = extractCredentials(this.userId);
 
-  check(meetingId, String);
-  check(requesterUserId, String);
-  check(stream, String);
+    check(meetingId, String);
+    check(requesterUserId, String);
+    check(stream, String);
 
-  Logger.info(`user unsharing webcam: ${meetingId} ${requesterUserId}`);
+    Logger.info(`user unsharing webcam: ${meetingId} ${requesterUserId}`);
 
-  // const actionName = 'joinVideo';
-  /* TODO throw an error if user has no permission to share webcam
-  if (!isAllowedTo(actionName, credentials)) {
-    throw new Meteor.Error('not-allowed', `You are not allowed to share webcam`);
-  } */
+    // const actionName = 'joinVideo';
+    /* TODO throw an error if user has no permission to share webcam
+    if (!isAllowedTo(actionName, credentials)) {
+      throw new Meteor.Error('not-allowed', `You are not allowed to share webcam`);
+    } */
 
-  const payload = {
-    stream,
-  };
+    const payload = {
+      stream,
+    };
 
-  return RedisPubSub.publishUserMessage(CHANNEL, EVENT_NAME, meetingId, requesterUserId, payload);
+    RedisPubSub.publishUserMessage(CHANNEL, EVENT_NAME, meetingId, requesterUserId, payload);
+  } catch (err) {
+    Logger.error(`Exception while invoking method userUnshareWebcam ${err.stack}`);
+  }
 }