Add check when start/stop an external video to prevent edge case

bigbluebutton-html5/imports/api/external-videos/server/methods/startWatchingExternalVideo.js

@@ -13,13 +13,19 @@ export default function startWatchingExternalVideo(options) {
   const { meetingId, requesterUserId } = extractCredentials(this.userId);
   const { externalVideoUrl } = options;
 
-  check(externalVideoUrl, String);
+  try {
+    check(meetingId, String);
+    check(requesterUserId, String);
+    check(externalVideoUrl, String);
 
-  Meetings.update({ meetingId }, { $set: { externalVideoUrl } });
+    Meetings.update({ meetingId }, { $set: { externalVideoUrl } });
 
-  const payload = { externalVideoUrl };
+    const payload = { externalVideoUrl };
 
-  Logger.info(`User id=${requesterUserId} sharing an external video: ${externalVideoUrl} for meeting ${meetingId}`);
+    Logger.info(`User id=${requesterUserId} sharing an external video: ${externalVideoUrl} for meeting ${meetingId}`);
 
-  return RedisPubSub.publishUserMessage(CHANNEL, EVENT_NAME, meetingId, requesterUserId, payload);
+    return RedisPubSub.publishUserMessage(CHANNEL, EVENT_NAME, meetingId, requesterUserId, payload);
+  } catch (error) {
+    Logger.error(`Error on sharing an external video: ${externalVideoUrl} ${error}`);
+  }
 }

bigbluebutton-html5/imports/api/external-videos/server/methods/stopWatchingExternalVideo.js

@@ -9,19 +9,22 @@ export default function stopWatchingExternalVideo(options) {
   const CHANNEL = REDIS_CONFIG.channels.toAkkaApps;
   const EVENT_NAME = 'StopExternalVideoMsg';
 
-  if (this.userId) {
-    options = extractCredentials(this.userId);
-  }
+  const { meetingId, requesterUserId } = this.userId ? this.userId : options;
 
-  const { meetingId, requesterUserId } = options;
+  try {
+    check(meetingId, String);
+    check(requesterUserId, String);
 
-  const meeting = Meetings.findOne({ meetingId });
-  if (!meeting || meeting.externalVideoUrl === null) return;
+    const meeting = Meetings.findOne({ meetingId });
+    if (!meeting || meeting.externalVideoUrl === null) return;
 
-  Meetings.update({ meetingId }, { $set: { externalVideoUrl: null } });
-  const payload = {};
+    Meetings.update({ meetingId }, { $set: { externalVideoUrl: null } });
+    const payload = {};
 
-  Logger.info(`User id=${requesterUserId} stopped sharing an external video for meeting=${meetingId}`);
+    Logger.info(`User id=${requesterUserId} stopped sharing an external video for meeting=${meetingId}`);
 
-  RedisPubSub.publishUserMessage(CHANNEL, EVENT_NAME, meetingId, requesterUserId, payload);
+    RedisPubSub.publishUserMessage(CHANNEL, EVENT_NAME, meetingId, requesterUserId, payload);
+  } catch (error) {
+    Logger.error(`Error on stop sharing an external video for meeting=${meetingId} ${error}`);
+  }
 }