From b103834bb23b2b10650003c397395e1ee89d7fb6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sa=C3=BAl=20Ibarra=20Corretg=C3=A9?= <saghul@gmail.com>
Date: Thu, 12 Jan 2017 08:59:14 -0600
Subject: [PATCH] Simplify rebuilding Node modules for Electron
---
README.md | 2 +-
electron_npm_rebuild | 14 --------------
package.json | 13 +++++++------
3 files changed, 8 insertions(+), 21 deletions(-)
delete mode 100755 electron_npm_rebuild
diff --git a/README.md b/README.md
index da7aac7..b20f0f1 100644
--- a/README.md
+++ b/README.md
@@ -8,7 +8,7 @@ from config.js
## Building the sources
```bash
-npm run build
+npm install
```
## Statring the application
diff --git a/electron_npm_rebuild b/electron_npm_rebuild
deleted file mode 100755
index 0b232d2..0000000
--- a/electron_npm_rebuild
+++ /dev/null
@@ -1,14 +0,0 @@
-# Electron's version.
-export npm_config_target=1.4.13
-# The architecture of Electron, can be ia32 or x64.
-export npm_config_arch=x64
-export npm_config_target_arch=x64
-# Download headers for Electron.
-export npm_config_disturl=https://atom.io/download/electron
-# Tell node-pre-gyp that we are building for Electron.
-export npm_config_runtime=electron
-# Tell node-pre-gyp to build module from source code.
-export npm_config_build_from_source=true
-
-
-HOME=./.electron-gyp npm install
diff --git a/package.json b/package.json
index cf56182..e187535 100644
--- a/package.json
+++ b/package.json
@@ -6,11 +6,11 @@
"productName": "Jitsi Meet",
"scripts": {
"start": "electron .",
- "build": "./electron_npm_rebuild",
- "clean": "rm -r node_modules .electron-gyp",
+ "clean": "rm -rf node_modules",
"lint": "eslint .",
- "validate": "npm ls",
- "pack": "electron-packager ."
+ "pack": "electron-packager .",
+ "postinstall": "electron-rebuild",
+ "validate": "npm ls"
},
"pre-commit": [
"lint"
@@ -35,9 +35,10 @@
},
"devDependencies": {
"electron": "1.4.13",
+ "electron-packager": "*",
+ "electron-rebuild": "^1.5.6",
"eslint": ">=3",
"eslint-plugin-jsdoc": "*",
- "precommit-hook": "3.0.0",
- "electron-packager": "*"
+ "precommit-hook": "3.0.0"
}
}
--
GitLab