Skip to content
Snippets Groups Projects
  1. Apr 16, 2021
    • Mario Jr's avatar
      298c4afd
    • Mario Jr's avatar
      fix: mic selection (firefox/all browsers) and muted alert when mic is changed · e8d59ed1
      Mario Jr authored
      This commit contains three fixes: one already reported and two detected
      during the investigation of the solution.
      This started as a fix for firefox (#12023), but i also fixed the muted
      alert/banner when device changes: the banner wasn't detecting device changes,
      unless audio was deactived/actived.
      
      There's another fix for the microphone stream: we now keep sender's track
      disabled if it was already disabled for the sender's track of the previous
      selected device.
      
      Also did small refactor for eslint checking.
      
      Some technical information: in sip bridge (bridge/sip.js), setInputStream and
      liveChangeInputDevice function were both fully turned into promises, which
      guarantees we have everything ready when it resolves to the respective values.
      This helps AudioManager (audio-manager/index.js) to sequentially sets and
      tracks the state of the current microphone stream (inputStream), when calling
      liveChangeInputDevice function: we first set the current stream to null,
      creats a new one and then set it to the newly created value - this is needed
      because MutedAlert (muted-alert/component.jsx) can then gracefully
      allocate/deallocate the cloned stream when it is set to a non-null/null value
      (the cloned stream is used for speech detection with hark).
      In MutedAlert we also make sure to enable the cloned stream's audio
      tracks, just in case the user change the device when muted (audio track is
      disabled in this case), which also leaves the cloned stream muted (we then
      enable the track to allow speech detection).
      
      Closes #12023
      e8d59ed1
  2. Apr 09, 2021
  3. Mar 29, 2021
    • Mario Jr's avatar
      Fixes and improvements on pr #10129 - dynamic change audio device · cddca95a
      Mario Jr authored
      Allow listenonly users to change output devices
      Fixed dynamic audio device change for firefox
      Fixed shortcuts for audio join/leave
      Show (with a bold font) the current selected device
      [performance] Prevent calling mediaDevices.enumerateDevices every time we render
      the selector. This adds a delay (~200ms, on my chrome setup) to render this component
      [performance] Do not call enumerateDevices to search for new devices, instead we listen on mediaDevices.deviceChange event
      Small refactoring and fixed a few errors that were being throw in browser's console
      Fixed device selection when this is done in audio-settings modal
      Fallback to default device when current device is removed
      Truncate device name length
      Renamed "Input","Output" labels to "Microphone","Speakers", respectively
      Update eslint rule for accessKey
      cddca95a
  4. Jun 21, 2019
  5. Jun 05, 2017
  6. Jun 02, 2017
Loading