From e8127fdb61c352cfa7d0d52d1a57421863b69069 Mon Sep 17 00:00:00 2001 From: Richard Alam <ritzalam@gmail.com> Date: Thu, 31 Aug 2017 08:06:15 -0700 Subject: [PATCH] - do not include recordings with bad metadata.xml in the response for recording api calls --- .../api/util/RecordingMetadataReaderHelper.java | 5 ----- .../org/bigbluebutton/web/controllers/ApiController.groovy | 2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/bbb-common-web/src/main/java/org/bigbluebutton/api/util/RecordingMetadataReaderHelper.java b/bbb-common-web/src/main/java/org/bigbluebutton/api/util/RecordingMetadataReaderHelper.java index abc9057031..d322abe3ff 100755 --- a/bbb-common-web/src/main/java/org/bigbluebutton/api/util/RecordingMetadataReaderHelper.java +++ b/bbb-common-web/src/main/java/org/bigbluebutton/api/util/RecordingMetadataReaderHelper.java @@ -49,11 +49,6 @@ public class RecordingMetadataReaderHelper { log.error("IOException on " + metadataXml.getAbsolutePath(), e); } - if (recMeta == null) { - recMeta = new RecordingMetadata(); - recMeta.setMetadataXml(metadataXml.getParentFile().getName()); - recMeta.setProcessingError(true); - } return recMeta; } diff --git a/bigbluebutton-web/grails-app/controllers/org/bigbluebutton/web/controllers/ApiController.groovy b/bigbluebutton-web/grails-app/controllers/org/bigbluebutton/web/controllers/ApiController.groovy index 88a3bd2e68..d32f07009f 100755 --- a/bigbluebutton-web/grails-app/controllers/org/bigbluebutton/web/controllers/ApiController.groovy +++ b/bigbluebutton-web/grails-app/controllers/org/bigbluebutton/web/controllers/ApiController.groovy @@ -1561,7 +1561,7 @@ class ApiController { returncode(RESP_CODE_SUCCESS) recordings(null) messageKey("noRecordings") - message("There are not recordings for the meetings") + message("There are no recordings for the meeting(s).") } } } -- GitLab