From dc0fc459e2a9c5917e2812ae96eeb1a71ff52693 Mon Sep 17 00:00:00 2001
From: hiroshisuga <45039819+hiroshisuga@users.noreply.github.com>
Date: Tue, 11 Aug 2020 23:04:58 +0900
Subject: [PATCH] events_archiver.rb: Handle an empty meeting_metadata hash
from redis
On my server 2.3 alpha, the method metadata_for(meeting_id) gives back {}
(empty Hash). Thus "return if meeting_metadata.nil?" does not occur.
Does @redis.hgetall give {} instead of nil, even though there is a comment in
node_modules/redis/lib/utils.js "hgetall converts its replies to an Object. If
the reply is empty, null is returned"???
---
.../core/lib/recordandplayback/events_archiver.rb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/record-and-playback/core/lib/recordandplayback/events_archiver.rb b/record-and-playback/core/lib/recordandplayback/events_archiver.rb
index 9b1198fe66..cf24377046 100755
--- a/record-and-playback/core/lib/recordandplayback/events_archiver.rb
+++ b/record-and-playback/core/lib/recordandplayback/events_archiver.rb
@@ -256,7 +256,7 @@ module BigBlueButton
end
meeting_metadata = @redis.metadata_for(meeting_id)
- return if meeting_metadata.nil?
+ return if meeting_metadata.nil? || meeting_metadata.empty?
# Fill in/update the top-level meeting element
if meeting.nil?
--
GitLab