From 7d6ade0e050cb7a4520542551bab14f4611db2e9 Mon Sep 17 00:00:00 2001
From: Gustavo Trott <gustavo@trott.com.br>
Date: Mon, 26 Apr 2021 17:38:30 -0300
Subject: [PATCH] brackets are not required and quotes should be used to
protect against spaces in the file names
---
bbb-libreoffice/assets/convert-local.sh | 4 ++--
bbb-libreoffice/assets/convert-remote.sh | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/bbb-libreoffice/assets/convert-local.sh b/bbb-libreoffice/assets/convert-local.sh
index 8e9f0a00a2..252a8e6943 100644
--- a/bbb-libreoffice/assets/convert-local.sh
+++ b/bbb-libreoffice/assets/convert-local.sh
@@ -23,8 +23,8 @@ fi;
mkdir -p "/tmp/bbb-soffice-$(whoami)/"
tempDir="$(mktemp -d -p /tmp/bbb-soffice-$(whoami)/)"
-source=${1}
-dest=${2}
+source="$1"
+dest="$2"
#If output format is missing, define PDF
convertTo="${3:-pdf}"
diff --git a/bbb-libreoffice/assets/convert-remote.sh b/bbb-libreoffice/assets/convert-remote.sh
index 74c672146c..8be6bfc6e5 100644
--- a/bbb-libreoffice/assets/convert-remote.sh
+++ b/bbb-libreoffice/assets/convert-remote.sh
@@ -21,12 +21,12 @@ elif (( $# == 1 )); then
fi;
-source=${1}
-dest=${2}
+source="$1"
+dest="$2"
#If output format is missing, define PDF
convertTo="${3:-pdf}"
-curl -X POST "http://127.0.0.1:8080/lool/convert-to/$convertTo" -H "accept: application/octet-stream" -H "Content-Type: multipart/form-data" -F "data=@${source}" > ${dest}
+curl -X POST "http://127.0.0.1:8080/lool/convert-to/$convertTo" -H "accept: application/octet-stream" -H "Content-Type: multipart/form-data" -F "data=@${source}" > "${dest}"
exit 0
--
GitLab