From 6e4ea312686644015bba882b5723ea42c4ef2482 Mon Sep 17 00:00:00 2001 From: jfederico <jesus@123it.ca> Date: Mon, 22 Aug 2016 17:22:00 -0400 Subject: [PATCH] bbb-lti: Parameters not required for the integration are not send to BBB --- .../org/bigbluebutton/BigbluebuttonService.groovy | 2 +- bbb-lti/src/java/org/bigbluebutton/api/Proxy.java | 12 +++++++++--- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/bbb-lti/grails-app/services/org/bigbluebutton/BigbluebuttonService.groovy b/bbb-lti/grails-app/services/org/bigbluebutton/BigbluebuttonService.groovy index 93ad700a6b..1a9d90e29f 100644 --- a/bbb-lti/grails-app/services/org/bigbluebutton/BigbluebuttonService.groovy +++ b/bbb-lti/grails-app/services/org/bigbluebutton/BigbluebuttonService.groovy @@ -198,7 +198,7 @@ class BigbluebuttonService { private String getCreateURL(String name, String meetingID, String attendeePW, String moderatorPW, String welcome, Integer voiceBridge, String logoutURL, String record, Integer duration, String meta ) { voiceBridge = ( voiceBridge == null || voiceBridge == 0 )? 70000 + new Random(System.currentTimeMillis()).nextInt(10000): voiceBridge; - String url = bbbProxy.getCreateURL(name, meetingID, attendeePW, moderatorPW, welcome, "", voiceBridge.toString(), "", logoutURL, "", record, duration.toString(), meta ); + String url = bbbProxy.getCreateURL(name, meetingID, attendeePW, moderatorPW, welcome, null, voiceBridge.toString(), null, logoutURL, null, record, duration.toString(), meta ); return url; } diff --git a/bbb-lti/src/java/org/bigbluebutton/api/Proxy.java b/bbb-lti/src/java/org/bigbluebutton/api/Proxy.java index 27d222af50..d6b0ca197e 100644 --- a/bbb-lti/src/java/org/bigbluebutton/api/Proxy.java +++ b/bbb-lti/src/java/org/bigbluebutton/api/Proxy.java @@ -79,10 +79,16 @@ public class Proxy { url += "&attendeePW=" + attendeePW; url += "&welcome=" + getStringEncoded(welcome); url += "&logoutURL=" + getStringEncoded(logoutURL); - url += "&maxParticipants=" + maxParticipants; url += "&voiceBridge=" + voiceBridge; - url += "&dialNumber=" + dialNumber; - url += "&webVoice=" + webVoice; + if ( maxParticipants != null ) { + url += "&maxParticipants=" + maxParticipants; + } + if ( dialNumber != null ) { + url += "&dialNumber=" + dialNumber; + } + if ( webVoice != null ) { + url += "&webVoice=" + webVoice; + } url += "&record=" + record; url += "&duration=" + duration; url += "&" + meta; -- GitLab