From 6db69c39d8885130153ce3202f74b88ee6bc33f2 Mon Sep 17 00:00:00 2001
From: Mario Jr <mariogasparoni@gmail.com>
Date: Tue, 20 Jul 2021 11:10:04 -0300
Subject: [PATCH] fix(audio): prevent duplicated error logging
We now let audio-manager log errors, using the specified error code.
These errors are still logged in bridge layer, but as a warning.
This commit doens't change error codes behavior, they are still being
logged as errors and with the same code numbers.
---
.../imports/api/audio/client/bridge/sip.js | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/bigbluebutton-html5/imports/api/audio/client/bridge/sip.js b/bigbluebutton-html5/imports/api/audio/client/bridge/sip.js
index 2aaf7cf227..a4d0279191 100755
--- a/bigbluebutton-html5/imports/api/audio/client/bridge/sip.js
+++ b/bigbluebutton-html5/imports/api/audio/client/bridge/sip.js
@@ -324,7 +324,8 @@ class SIPSession {
const timeout = setTimeout(() => {
trackerControl.stop();
- logger.error({ logCode: 'sip_js_transfer_timed_out' }, 'Timeout on transferring from echo test to conference');
+ logger.warn({ logCode: 'sip_js_transfer_timed_out' },
+ 'Timeout on transferring from echo test to conference');
this.callback({
status: this.baseCallStates.failed,
error: 1008,
@@ -928,14 +929,14 @@ class SIPSession {
const handleIceNegotiationFailed = (peer) => {
if (iceCompleted) {
- logger.error({
+ logger.warn({
logCode: 'sipjs_ice_failed_after',
extraInfo: {
callerIdName: this.user.callerIdName,
},
}, 'ICE connection failed after success');
} else {
- logger.error({
+ logger.warn({
logCode: 'sipjs_ice_failed_before',
extraInfo: {
callerIdName: this.user.callerIdName,
@@ -955,7 +956,7 @@ class SIPSession {
const handleIceConnectionTerminated = (peer) => {
if (!this.userRequestedHangup) {
- logger.error({
+ logger.warn({
logCode: 'sipjs_ice_closed',
extraInfo: {
callerIdName: this.user.callerIdName,
@@ -1082,7 +1083,7 @@ class SIPSession {
mappedCause = '1005';
}
- logger.error({
+ logger.warn({
logCode: 'sip_js_call_terminated',
extraInfo: { cause, callerIdName: this.user.callerIdName },
}, `Audio call terminated. cause=${cause}`);
@@ -1111,7 +1112,7 @@ class SIPSession {
handleSessionTerminated();
break;
default:
- logger.error({
+ logger.warn({
logCode: 'sipjs_ice_session_unknown_state',
extraInfo: {
callerIdName: this.user.callerIdName,
--
GitLab