From 5780bd4efea18ccf55bf5ffba5228e076c79c2e2 Mon Sep 17 00:00:00 2001
From: Richard Alam <ritzalam@gmail.com>
Date: Fri, 16 Mar 2018 10:05:02 -0700
Subject: [PATCH] - convert logs to printlns to silence fortify scans. Turning
to printlns still helps in debugging during development.
---
.../sample/servlet/JnlpDownloadServlet.java | 26 +++++++++----------
.../jnlp/sample/servlet/JnlpFileHandler.java | 6 ++---
.../jnlp/sample/servlet/ResourceCatalog.java | 4 +--
3 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/bbb-screenshare/app/src/main/java/jnlp/sample/servlet/JnlpDownloadServlet.java b/bbb-screenshare/app/src/main/java/jnlp/sample/servlet/JnlpDownloadServlet.java
index ad276853c9..5688371877 100755
--- a/bbb-screenshare/app/src/main/java/jnlp/sample/servlet/JnlpDownloadServlet.java
+++ b/bbb-screenshare/app/src/main/java/jnlp/sample/servlet/JnlpDownloadServlet.java
@@ -85,13 +85,13 @@ public class JnlpDownloadServlet extends HttpServlet {
// Parse HTTP request
DownloadRequest dreq = new DownloadRequest(getServletContext(), request);
- if (log.isInfoEnabled()) {
- log.info("servlet.log.info.request", requestStr);
- log.info("servlet.log.info.useragent", request.getHeader("User-Agent"));
- }
- if (log.isDebugEnabled()) {
- log.debug(dreq.toString());
- }
+// if (log.isInfoEnabled()) {
+// log.info("servlet.log.info.request", requestStr);
+// log.info("servlet.log.info.useragent", request.getHeader("User-Agent"));
+// }
+// if (log.isDebugEnabled()) {
+// log.debug(dreq.toString());
+// }
long ifModifiedSince = request.getDateHeader("If-Modified-Since");
@@ -143,12 +143,12 @@ public class JnlpDownloadServlet extends HttpServlet {
dres.sendRespond(response);
} catch(ErrorResponseException ere) {
- if (log.isInfoEnabled()) {
- log.info("servlet.log.info.badrequest", requestStr);
- }
- if (log.isDebugEnabled()) {
- log.debug("Response: "+ ere.toString());
- }
+// if (log.isInfoEnabled()) {
+// log.info("servlet.log.info.badrequest", requestStr);
+// }
+// if (log.isDebugEnabled()) {
+// log.debug("Response: "+ ere.toString());
+// }
// Return response from exception
ere.getDownloadResponse().sendRespond(response);
} catch(Throwable e) {
diff --git a/bbb-screenshare/app/src/main/java/jnlp/sample/servlet/JnlpFileHandler.java b/bbb-screenshare/app/src/main/java/jnlp/sample/servlet/JnlpFileHandler.java
index 75b8cda798..1568e6e99e 100755
--- a/bbb-screenshare/app/src/main/java/jnlp/sample/servlet/JnlpFileHandler.java
+++ b/bbb-screenshare/app/src/main/java/jnlp/sample/servlet/JnlpFileHandler.java
@@ -358,9 +358,9 @@ public class JnlpFileHandler {
jnlpTemplate = substitute(jnlpTemplate, "$$context", urlprefix + request.getContextPath());
// fix for 6256326: add $$site macro to sample jnlp servlet
jnlpTemplate = substitute(jnlpTemplate, "$$site", urlprefix);
-
-
- log.info("JNLP Response: " + jnlpTemplate);
+
+
+ System.out.println("JNLP Response: " + jnlpTemplate);
return jnlpTemplate;
}
diff --git a/bbb-screenshare/app/src/main/java/jnlp/sample/servlet/ResourceCatalog.java b/bbb-screenshare/app/src/main/java/jnlp/sample/servlet/ResourceCatalog.java
index 978107a518..785c824579 100755
--- a/bbb-screenshare/app/src/main/java/jnlp/sample/servlet/ResourceCatalog.java
+++ b/bbb-screenshare/app/src/main/java/jnlp/sample/servlet/ResourceCatalog.java
@@ -421,13 +421,13 @@ public class ResourceCatalog {
err.getMessage());
return;
} catch (Throwable t) {
- log.warn("servlet.log.warning.xml.reading", versionRes.getPath(), t);
+ System.out.println("servlet.log.warning.xml.reading=" + versionRes.getPath() + "\n" + t);
return;
}
// Check that root element is a <jnlp> tag
if (!root.getName().equals("jnlp-versions")) {
- log.warn("servlet.log.warning.xml.missing-jnlp", versionRes.getPath());
+ System.out.println("servlet.log.warning.xml.missing-jnlp=" + versionRes.getPath());
return;
}
--
GitLab