From 4f59580f6be108029c12716fc37c606eafa33111 Mon Sep 17 00:00:00 2001
From: Chad Pilkey <capilkey@gmail.com>
Date: Tue, 30 Apr 2019 15:29:30 -0700
Subject: [PATCH] video preview spacing and localized strings
---
.../ui/components/video-preview/component.jsx | 12 ++++++++++--
.../imports/ui/components/video-preview/styles.scss | 1 +
bigbluebutton-html5/private/locales/en.json | 2 ++
3 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/bigbluebutton-html5/imports/ui/components/video-preview/component.jsx b/bigbluebutton-html5/imports/ui/components/video-preview/component.jsx
index 09d1ad54b6..542e6e9480 100755
--- a/bigbluebutton-html5/imports/ui/components/video-preview/component.jsx
+++ b/bigbluebutton-html5/imports/ui/components/video-preview/component.jsx
@@ -39,6 +39,10 @@ const intlMessages = defineMessages({
id: 'app.videoPreview.cameraLabel',
description: 'Camera dropdown label',
},
+ qualityLabel: {
+ id: 'app.videoPreview.profileLabel',
+ description: 'Quality dropdown label',
+ },
cancelLabel: {
id: 'app.videoPreview.cancelLabel',
description: 'Cancel button label',
@@ -55,6 +59,10 @@ const intlMessages = defineMessages({
id: 'app.videoPreview.webcamNotFoundLabel',
description: 'Webcam not found label',
},
+ profileNotFoundLabel: {
+ id: 'app.videoPreview.profileNotFoundLabel',
+ description: 'Profile not found label',
+ },
permissionError: {
id: 'app.video.permissionError',
description: 'Error message for webcam permission',
@@ -445,7 +453,7 @@ class VideoPreview extends Component {
</span>
)}
<label className={styles.label}>
- {'Quality'}
+ {intl.formatMessage(intlMessages.qualityLabel)}
</label>
{availableProfiles && availableProfiles.length > 0 ? (
<select
@@ -462,7 +470,7 @@ class VideoPreview extends Component {
)
: (
<span>
- {'No supported profiles'}
+ {intl.formatMessage(intlMessages.profileNotFoundLabel)}
</span>
)}
</div>
diff --git a/bigbluebutton-html5/imports/ui/components/video-preview/styles.scss b/bigbluebutton-html5/imports/ui/components/video-preview/styles.scss
index 00a5518585..e77914ac47 100755
--- a/bigbluebutton-html5/imports/ui/components/video-preview/styles.scss
+++ b/bigbluebutton-html5/imports/ui/components/video-preview/styles.scss
@@ -51,6 +51,7 @@
}
.label {
+ margin-top: 8px;
font-size: 0.85rem;
font-weight: bold;
color: var(--color-gray-label);
diff --git a/bigbluebutton-html5/private/locales/en.json b/bigbluebutton-html5/private/locales/en.json
index 032e5304ad..d1df539806 100755
--- a/bigbluebutton-html5/private/locales/en.json
+++ b/bigbluebutton-html5/private/locales/en.json
@@ -456,6 +456,7 @@
"app.recording.startDescription": "(You can select the record button again later to pause the recording.)",
"app.recording.stopDescription": "Are you sure you want to pause the recording? (You can resume by selecting the record button again.)",
"app.videoPreview.cameraLabel": "Camera",
+ "app.videoPreview.profileLabel": "Quality",
"app.videoPreview.cancelLabel": "Cancel",
"app.videoPreview.closeLabel": "Close",
"app.videoPreview.startSharingLabel": "Start sharing",
@@ -463,6 +464,7 @@
"app.videoPreview.webcamPreviewLabel": "Webcam preview",
"app.videoPreview.webcamSettingsTitle": "Webcam settings",
"app.videoPreview.webcamNotFoundLabel": "Webcam not found",
+ "app.videoPreview.profileNotFoundLabel": "No supported profile",
"app.video.joinVideo": "Share webcam",
"app.video.leaveVideo": "Stop sharing webcam",
"app.video.iceCandidateError": "Error on adding ICE candidate",
--
GitLab