From 43482bae0841f91ac2158a7c9169a7bff49d9604 Mon Sep 17 00:00:00 2001 From: Anton Georgiev <anto.georgiev@gmail.com> Date: Thu, 18 Jul 2019 21:37:56 +0000 Subject: [PATCH] do not log clientInfo with each log, just the joinhandler one --- .../imports/ui/components/join-handler/component.jsx | 2 +- bigbluebutton-html5/imports/ui/services/api/index.js | 11 +---------- bigbluebutton-html5/imports/ui/services/auth/index.js | 2 -- 3 files changed, 2 insertions(+), 13 deletions(-) diff --git a/bigbluebutton-html5/imports/ui/components/join-handler/component.jsx b/bigbluebutton-html5/imports/ui/components/join-handler/component.jsx index fcf16895b3..1d558926e4 100644 --- a/bigbluebutton-html5/imports/ui/components/join-handler/component.jsx +++ b/bigbluebutton-html5/imports/ui/components/join-handler/component.jsx @@ -88,7 +88,7 @@ class JoinHandler extends Component { logCode: 'joinhandler_component_clientinfo', extraInfo: { clientInfo }, }, - 'Log informatin about the client'); + 'Log information about the client'); }; const setAuth = (resp) => { diff --git a/bigbluebutton-html5/imports/ui/services/api/index.js b/bigbluebutton-html5/imports/ui/services/api/index.js index db06d89968..fc4f155d8c 100755 --- a/bigbluebutton-html5/imports/ui/services/api/index.js +++ b/bigbluebutton-html5/imports/ui/services/api/index.js @@ -47,15 +47,7 @@ export function call(name, ...args) { export function log(type = 'error', message, ...args) { const { credentials } = Auth; - const userInfo = window.navigator; - const clientInfo = { - language: userInfo.language, - userAgent: userInfo.userAgent, - screenSize: { width: window.screen.width, height: window.screen.height }, - windowSize: { width: window.innerWidth, height: window.innerHeight }, - bbbVersion: Meteor.settings.public.app.bbbServerVersion, - location: window.location.href, - }; + const logContents = { ...args }; const topic = logContents[0] ? logContents[0].topic : null; @@ -63,7 +55,6 @@ export function log(type = 'error', message, ...args) { console.debug(`CLIENT LOG (${topic ? `${type.toUpperCase()}.${topic}` : type.toUpperCase()}): `, messageOrStack, ...args); Meteor.call('logClient', type, messageOrStack, { - clientInfo, credentials, ...args, }); diff --git a/bigbluebutton-html5/imports/ui/services/auth/index.js b/bigbluebutton-html5/imports/ui/services/auth/index.js index 7d0c83ff55..cd22b3c022 100755 --- a/bigbluebutton-html5/imports/ui/services/auth/index.js +++ b/bigbluebutton-html5/imports/ui/services/auth/index.js @@ -132,8 +132,6 @@ class Auth { sessionToken: this.sessionToken, meetingId: this.meetingID, requesterUserId: this.userID, - fullname: this.fullname, - confname: this.confname, externUserID: this.externUserID, uniqueClientSession: this.uniqueClientSession, }; -- GitLab